Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround for ios 11 bug #344

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Workaround for ios 11 bug #344

wants to merge 2 commits into from

Conversation

jhubble
Copy link

@jhubble jhubble commented Nov 17, 2017

The code causes the iOS 11 keyboard to overlay an input field, making it impossible to see what is being typed. Commenting it out fixes the issue.

@jackmoore jackmoore mentioned this pull request Jan 13, 2018
Open
@Christilut
Copy link

Can this PR get merged?

@jackmoore
Copy link
Owner

@Christilut See my comment about this. The code this pull request removes reopens a serious issue.

@amitdiamant
Copy link

amitdiamant commented Aug 2, 2018 •
edited
Loading

This also works:

// prevents scroll-position jumping
            overflows.forEach(function (el) {
                if (el.node.scrollTop !== el.scrollTop) {
                    el.node.scrollTop = el.scrollTop;
                }
            });

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jhubble @Christilut @jackmoore @amitdiamant